This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Add sample_type field to permit in-code samples. #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
yihanzhen
reviewed
Oct 9, 2019
| // in-code samples for the same RPC before including them in the | ||
| // library source code). If not specified or empty, defaults to | ||
| // ["standalone"] | ||
| repeated string sample_type = 10 |
There was a problem hiding this comment.
This is not compiling - please add a comma after 10
vchudnov-g
force-pushed
the
incodesample
branch
from
ac7b0dd
to
adf6359
Compare
software-dov
reviewed
Oct 9, 2019
src/main/proto/com/google/api/codegen/samplegen/v1p2/sample_config_v1p2.proto
Show resolved
Hide resolved
yihanzhen
approved these changes
Oct 9, 2019
|
Is this review still open? |
software-dov
approved these changes
Oct 16, 2019
vchudnov-g
force-pushed
the
incodesample
branch
4 times, most recently
from
b525fb6
to
d1fb3a8
Compare
vchudnov-g
force-pushed
the
incodesample
branch
from
d1fb3a8
to
5f7c51b
Compare
|
Merged with master. I had to tweak the circle config file to make CircleCI pass on my fork. For some reason, the I don't know why this was passing on the main repo even though it was failing on my fork. PTAL @hzyi-google @software-dov @jbolinger |
This was referenced Nov 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optional field in the sample config. If it is not provided, generators should emit standalone samples only for the given config. (This preserves backward compatibility with uses of the current schema.)